-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyfakefs usage scenarios #189
Comments
Thank you for thinking so deeply about this. I generally understand and agree. Could I ask you to separate these into two or three paragraphs or perhaps even separate issues? Also, please specify "one" in "...none seems to be using that one." |
Okay, I created a few more issues that can be handled separately. Do you think this is something for the next release? And thanks for the 3.2 release, by the way - you have done a lot of documentation cleanup, I liked that. |
Sure, this is an excellent target for 3.3. |
Great! Note I won't have access to a computer for a couple of weeks - I will finish the nanosecond time related issues afterwards. |
Bon voyage. |
Thanks, having that! |
- changed test to test the real glob with the fake filesystem - see pytest-dev#189
- changed test to test the real glob with the fake filesystem - see pytest-dev#189
- removed tempfile and glob modules from module list - moved temp dir generation code from TestCase into Patcher - see #189
Remaining task: adapt README.MD. |
All done - closing. |
This is more of a discussion point than an issue, and also for a later release.
I wonder if there is really the need to use pyfakefs via mock (the third scenario), given that you always can use
Patcher
directly if not usingunittest
orpytest
. From what I have seen from contributors so far, none of them seems to be using themock
scenario.Anyway, I doubt the usefulness of mocking
glob
,tempfile
orshutil
separately, but maybe I'm wrong here. On the other hand, if removing that scenario for these modules,fake_filesystem_glob
and probablyfake_tempfile
(which is implemented incompletely anyway) can be removed, and most fromfake_filesystem_shutil
implementation also (though this needs some additions in FakeOsModule).Edit: I moved some of the points into separate issues that can be implemented independently (#191, #192, #193 and #194).
What remains for this issue:
mock
scenario withPatcher
scenario)glob
andtempfile
implementationThe text was updated successfully, but these errors were encountered: