Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newline argument in fake open() incorrectly handled #339

Closed
mrbean-bremen opened this issue Jan 1, 2018 · 0 comments
Closed

newline argument in fake open() incorrectly handled #339

mrbean-bremen opened this issue Jan 1, 2018 · 0 comments
Labels
bug

Comments

@mrbean-bremen
Copy link
Member

This is a spin-off of #303.
The result from using fake open() with newline=\r or newline=\r\n differs from the real OS behavior (see FakeFileOpenTest.test_open_newline_arg).
Additionally, there are specific problems under Windows where the line endings are \n instead of \r\n in some cases (see FakeFileOpenTest.test_open_with_append_flag).
mrbean-bremen added a commit that referenced this issue Jan 29, 2018
@mrbean-bremen
Added own text stream buffer to correctly handle newlines
c80d0be 
- fixed/added tests for newline support, added real fs tests
- see #339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrbean-bremen