Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.link is implemented to make symlinks instead of hardlinks #75

Closed
sruggier opened this issue Mar 25, 2016 · 3 comments
Closed

os.link is implemented to make symlinks instead of hardlinks #75

sruggier opened this issue Mar 25, 2016 · 3 comments
Labels

Comments

@sruggier
Copy link
Contributor

I was trying to use the atomicwrites package under pyfakefs, and after adding fsync support (see #73), the next issue I noticed was that the fake version of os.link is aliased to the fake os.symlink, which has very different behaviour in cases where the original file is renamed or deleted:

  # TODO: Link doesn't behave like os.link, this needs to be fixed properly.
  link = symlink
@jmcgeheeiv
Copy link
Contributor

Excellent observation. It would be fabulous if you could issue a pull request for this, too.

@sruggier
Copy link
Contributor Author

sruggier commented Apr 9, 2016

Yeah, I've been working on it on and off. I have a working implementation that I'll make a PR out sometime in the next few days.

@jmcgeheeiv
Copy link
Contributor

Considering this fixed by #95 and #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants