Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of test failures with PyPy3.10 7.3.12 #859

Closed
mgorny opened this issue Jul 8, 2023 · 7 comments
Closed

Lots of test failures with PyPy3.10 7.3.12 #859

mgorny opened this issue Jul 8, 2023 · 7 comments

Comments

@mgorny
Copy link
Contributor

mgorny commented Jul 8, 2023

Describe the bug
When running the test suite with PyPy3.10 7.3.12, I get loads of test failures. The following bit seems to repeat a lot:

Traceback (most recent call last):
  File "/tmp/pyfakefs/pyfakefs/tests/fake_filesystem_test.py", line 1433, in test_alt_sep
    fake_os_module = fake_os.FakeOsModule(self.filesystem)
  File "/tmp/pyfakefs/pyfakefs/fake_os.py", line 1356, in wrapped
    return f(*args, **kwargs)
TypeError: object.__new__() takes exactly one argument (the type to instantiate)

Full log (1M): pypy310.txt

How To Reproduce

tox -e pypy310

Your environment
Please run the following in the environment where the problem happened and
paste the output.

$ python -c "import platform; print(platform.platform())"
Linux-6.3.11-gentoo-dist-x86_64-AMD_Ryzen_5_3600_6-Core_Processor-with-glibc2.37
$ python -c "import sys; print('Python', sys.version)"
Python 3.10.12 (af44d0b8114cb82c40a07bb9ee9c1ca8a1b3688c, Jun 16 2023, 13:56:29)
[PyPy 7.3.12 with GCC 12.2.1 20230428]
$ python -c "from pyfakefs import __version__; print('pyfakefs', __version__)"
pyfakefs 5.3.dev0
$ python -c "import pytest; print('pytest', pytest.__version__)"
pytest 7.4.0

I've originally noticed it on 5.2.2, and tested on 78d173b to confirm.

@mrbean-bremen
Copy link
Member

Thank you, I will have a look!

mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Jul 9, 2023
- adapt to some changed behavior
- add another SKIPMODULE for pytest
- add tests for more pypy versions
- see pytest-dev#859
mrbean-bremen added a commit that referenced this issue Jul 9, 2023
- adapt to some changed behavior
- add another SKIPMODULE for pytest
- add tests for more pypy versions
- see #859
@mrbean-bremen
Copy link
Member

@mgorny - shall be fixed in main now, please check!

@mgorny
Copy link
Contributor Author

mgorny commented Jul 10, 2023

Thanks. I can confirm that it passes now, except for some assertion from pandas — but that's not a bug in pyfakefs.

@mrbean-bremen
Copy link
Member

Do you need a patch release for packaging, or can this wait?

@mgorny
Copy link
Contributor Author

mgorny commented Jul 10, 2023

I would find a new release very helpful but if that's a lot of trouble, we can try to backport the patches in Gentoo.

@mrbean-bremen
Copy link
Member

mrbean-bremen commented Jul 10, 2023

Sure, a release is no trouble at all. Released as 5.2.3, and closing as fixed.

@mgorny
Copy link
Contributor Author

mgorny commented Jul 10, 2023

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants