Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling Subfactory fixture replacing - might create circular dependencies #69

Open
charlax opened this issue Oct 19, 2018 · 2 comments

Comments

@charlax
Copy link

charlax commented Oct 19, 2018

Because pytest-factoryboy replaces SubFactory with registered factories, it is possible to inadvertently create circular dependencies, which are not detected by pytest.

In my case, the setup was the following:

  1. User factory
  2. Company factory with a Contact subfactory.
  3. user fixture overridden in the test file, depending on the company fixture
  4. contact fixture overridden in the same file, depending on the company fixture.

Normally it should be fine because user -> company and contact -> company - there's no cycle. But, because the plugin creates a dependency company -> contact, the graph becomes: user -> company -> contact -> company and there's a cycle. Yet this cycle is a bit magical - I did not ask for company.contact and contact.company to be the same... I want a new, unrelated contact to be created for each company.

Would it be possible to add an option to disable this for those who don't need it? Or only some whitelisted subfactories? In my case, I would like the company.contact factory to be unrelated to the contact factory.

@charlax
Copy link
Author

charlax commented May 17, 2019

Any update here? This is a big issue for me...

@youtux
Copy link
Contributor

youtux commented Jul 23, 2023

Apologies for missing this. Is it still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants