Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to previous txt file deletion behavior #2854

Open
swfarnsworth opened this issue Dec 18, 2023 · 7 comments
Open

Revert to previous txt file deletion behavior #2854

swfarnsworth opened this issue Dec 18, 2023 · 7 comments
Assignees
Labels
a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority status: approved The issue has received a core developer's approval

Comments

@swfarnsworth
Copy link
Member

Prior to the filtering system rewrite, if a user entered a message that was too long, the bot would delete the message and respond with this message in the channel where the deleted message was posted.

image

The current behavior is that the bot will send a direct message to the user.

Anecdotally, the current behavior seems to be less effective. I frequently see people try to post the same message multiple times and complain that the bot keeps deleting their message, without the user seeing or acting upon the direct message from the bot.

We should revert to the previous behavior of sending a message in the channel where the long message (or txt file) was posted.

@swfarnsworth swfarnsworth added a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority labels Dec 18, 2023
@Esther-Goldberg
Copy link
Member

is this being worked on, or can I work on it?

@jb3
Copy link
Member

jb3 commented Apr 8, 2024

Doesn't look like anyone has assigned to this issue yet, I will assign you now!

@Esther-Goldberg
Copy link
Member

It looks like the current filtering system doesn't have a setting to send embeds in the original channel, so that would have to be added

@Esther-Goldberg
Copy link
Member

assuming we also want this for .py files

@jb3 jb3 added the status: approved The issue has received a core developer's approval label Apr 9, 2024
@mbaruh
Copy link
Member

mbaruh commented Apr 9, 2024

Yeah some setting(s) needs to be added here.

I'm wondering what the correct approach here is: We could have a setting for whether to DM the message or send it in the public channel (in which case it might make sense to change the names of dm_content and dm_embed since it wouldn't necessarily be a DM anymore), or we could add a setting that allows sending the message publicly as a fallback if sending the DM fails (usually because they have DMs off).

@Esther-Goldberg
Copy link
Member

People don't necessarily check their DMs in the middle of using a help channel, so in this case we probably want to put an embed in the channel even if they have DMs open.

@mbaruh
Copy link
Member

mbaruh commented Apr 9, 2024

Yeah that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority status: approved The issue has received a core developer's approval
Projects
None yet
Development

No branches or pull requests

4 participants