Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of isort-related errors and other autofix codes #29

Open
jhossbach opened this issue Apr 4, 2023 · 4 comments
Open

Handling of isort-related errors and other autofix codes #29

jhossbach opened this issue Apr 4, 2023 · 4 comments
Labels
question Further information is requested

Comments

@jhossbach
Copy link
Member

jhossbach commented Apr 4, 2023

With #25 being merged soon, the question remains whether formatting should be enabled by default and error codes should be given to be auto-fixed when running formatting.
I don't really mind on or the other, so I'm open to suggestions.

If e.g. isort-codes should be used for formatting per default, we should also disable pylsp-isort.

@jhossbach jhossbach changed the title Handling of isort-related errors Handling of isort-related errors and other autofix codes Apr 4, 2023
@Shane-XB-Qian
Copy link
Contributor

i am curious to ask if this can offer 'additionalTextEdits' which offer auto-fix for auto-import when writing a method but did not import it yet.

@jhossbach
Copy link
Member Author

That depends on whether ruff supports this kind of action. I couldn't find any immediate support for that, but as far as I know rope (and thus pylsp-rope) supports this.

@Shane-XB-Qian
Copy link
Contributor

Shane-XB-Qian commented Apr 21, 2023 via email

@jhossbach
Copy link
Member Author

You could create a feature request issue on ruff's github but i think the idea of ruff is to stay on providing linting features rather than code reformat actions. Nevertheless it might be worth the try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants