Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of required fields inconsistent #373

Open
Archelyst opened this issue Aug 9, 2024 · 0 comments
Open

Validation of required fields inconsistent #373

Archelyst opened this issue Aug 9, 2024 · 0 comments

Comments

@Archelyst
Copy link

Archelyst commented Aug 9, 2024

The validation of the required keyword does not make sense as it is implemented right now, IMHO.

  1. It really does not make any sense to list properties in required that do not exist.
  2. If you want to use it with allOf and therefore have properties in required that do not exist, there are already precautions (feat: handle allof when required linked to parent object (#97) #154).
  3. Currently, there is no validation error in the standard case but as soon as I have allOf in my schema, there is a validation error. That is inconsistent. The PR that breaks it: Allow undefined required properties #312
  4. In $referenced schemas, the validation does not take effect either.

One of the main reasons why this should urgently be validated (as was in version 0.7.0) is that validators (that use the specification to validate requests/responses) will fail if there is e.g. a typo in one of the entries in required. And now there is no way to detect that.

In general, the OpenAPI/JsonSchema specification is quite relaxed. If only the bare minimum should be validated, this is probably not the only validation that can basically be removed completely.

My take on this:

  1. Best case: Throw validation errors for things that are obvious errors (like specifying a field as required that does not even exist).
  2. Second best option: make it configurable ("strict mode") or filterable (error IDs to exclude, filter levels, ...).
  3. Absolutely necessary minium: make it consistent.

I'd be willing to provide a PR. But since this has been going back and forth I'd like a decision first, where this is going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant