Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit_bounds seems to fail when multiple maps/cells are rendered in a notebook #2080

Open
bdnewto opened this issue Jan 16, 2025 · 2 comments
Open

Comments

@bdnewto
Copy link

bdnewto commented Jan 16, 2025

Describe the bug
Since about September of 2024 I've noticed that folium seems to sometimes fail to correctly "apply" fit_bounds to maps when multiple maps are rendered back-to-back. Manually running map generation cells a second time seems to cause the map to zoom/fit correctly. Have others experienced this?

To Reproduce
[update] I'm happy to report that I now have a concise notebook the reproduces this issue for me consistently.
FitBoundsTest.txt Rename as .ipynb

The issue seems to be related to whether the call to the map rendering function is on or off screen at the time it gets executed. In my browsers, calling "restart kernel and run all" on this notebook causes the notebook to scroll to the start of the last cell where I have some filler_text which fills the screen, yet the last call to test() is barely visible. If I don't scroll during the execution of the cells, once the run is complete, when I do scroll up almost always the first map has not "zoomed" (fit to bounds correctly),
Screenshot from 2025-01-16 08-13-15
Sometimes the second map is also not "zoomed" correctly, but always the third is. If I remove the filler text (or move it to the top) and restart and run all again, all 3 maps "zoom" correctly. Similarly, if I scroll up to the calls to test() while it is "running all", it also succeeds every time. And, if I manually re-run a single cell that failed to zoom correctly during run all, it then zooms correctly. I hope that helps find and fix the issue. Please let me know how I can be of more assistance.

Expected behavior
All maps correctly fit to bounds as expected.

Environment (please complete the following information):

Current setup, though I've seen it in other settings as well. I believe on windows.

  • Browser: Firefox and Chrome
  • Jupyter Notebook or html files? Jupyter
  • Python version: 3.11.8
  • folium version: 0.19.4
  • branca version: 0.8.1

Additional context
Never saw this before the end of September 2024, but now see it many places.

Possible solutions
?

folium is maintained by volunteers. Can you help making a fix for this issue?
Maybe

@hansthen
Copy link
Collaborator

Do you have some example code? It would really help to reproduce the issue even if only intermittently.

@bdnewto
Copy link
Author

bdnewto commented Jan 16, 2025

I have some example code now added to the original post. Thank you for looking into this, and let me know how I can help further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants