Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC Separate Emscripten and WASI standard lib disables in configure #126178

Closed
hoodmane opened this issue Oct 30, 2024 · 0 comments · Fixed by #126179
Closed

NFC Separate Emscripten and WASI standard lib disables in configure #126178

hoodmane opened this issue Oct 30, 2024 · 0 comments · Fixed by #126179
Labels
build The build process and cross-build OS-emscripten

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Oct 30, 2024 •
edited by bedevere-app bot
Loading

In configure.ac in the "Modules that are not available on some platforms" we PY_STDLIB_MOD_SET_NA a bunch of standard library modules that either won't compile or won't work in Emscripten and WASI. Currently these two targets are overlapped, so there's a top level check for Emscripten|WASI and then a subcheck to decide which of the two cases we are dealing with. This entanglement minorly complicates maintenance of these targets. They should be disentangled.

This is a nonfunctional change.

Linked PRs
hoodmane added a commit to hoodmane/cpython that referenced this issue Oct 30, 2024
@hoodmane
pythongh-126178: NFC Separate Emscripten and WASI standard lib disabl…
3ae7010 
…es in configure
@bedevere-app bedevere-app bot mentioned this issue Oct 30, 2024
Merged
@erlend-aasland erlend-aasland linked a pull request Oct 30, 2024 that will close this issue
gh-126178: NFC Separate Emscripten and WASI standard lib disables in configure #126179
Merged
@erlend-aasland erlend-aasland added the build The build process and cross-build label Oct 30, 2024
freakboy3742 pushed a commit that referenced this issue Oct 31, 2024
@hoodmane
gh-126178: NFC Separate Emscripten and WASI standard lib disables in …
b3122aa 
…configure (#126179)

Separate the Emscripten and WASI stdlib configuration in configure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-126178: NFC Separate Emscripten and WASI standard lib disables in configure hoodmane/cpython
3 participants
@brettcannon @hoodmane @erlend-aasland