Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time.rst uses the same than, which is grammatically incorrect #126256

Closed
alpaylan opened this issue Oct 31, 2024 · 3 comments
Closed

time.rst uses the same than, which is grammatically incorrect #126256

alpaylan opened this issue Oct 31, 2024 · 3 comments
Labels
docs Documentation in the Doc dir easy

Comments

@alpaylan
Copy link
Contributor

alpaylan commented Oct 31, 2024 •
edited by bedevere-app bot
Loading

Documentation

The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false as far as I can tell.

Linked PRs
@alpaylan alpaylan added the docs Documentation in the Doc dir label Oct 31, 2024
@picnixz picnixz added the easy label Oct 31, 2024
@sobolevn
Copy link
Member

PR is welcome!

@alpaylan alpaylan mentioned this issue Oct 31, 2024
Merged
alpaylan added a commit to alpaylan/cpython that referenced this issue Oct 31, 2024
@alpaylan
Merge pull request #1 from alpaylan/the-same-clock-as
c1b9766 
pythongh-126256: Update time.rst to use `the same clock as` instead of `the same clock than`
@alpaylan alpaylan mentioned this issue Oct 31, 2024
Merged
@alpaylan
Copy link
Contributor Author

I accidentally opened the PR in my fork first 🤕 Opened it now.

sobolevn pushed a commit that referenced this issue Oct 31, 2024
@alpaylan
gh-126256: Update time.rst to use the same clock as instead of the sa…
d0abd0b 
…me clock than (#126257)

Update time.rst to use `the same clock as` instead of `the same clock than`

The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 31, 2024
@alpaylan @miss-islington
pythongh-126256: Update time.rst to use the same clock as instead of …
ecfb618 
…the same clock than (pythonGH-126257)

Update time.rst to use `the same clock as` instead of `the same clock than`

The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`.
(cherry picked from commit d0abd0b)

Co-authored-by: Alperen Keleş <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 31, 2024
Merged
@sobolevn
Copy link
Member

Thanks! I set backport PRs for automerge, going to close this issue.

sobolevn pushed a commit that referenced this issue Oct 31, 2024
@miss-islington @alpaylan
[3.13] gh-126256: Update time.rst to use the same clock as instead of…
256fc55 
… the same clock than (GH-126257) (#126258)

gh-126256: Update time.rst to use the same clock as instead of the same clock than (GH-126257)

Update time.rst to use `the same clock as` instead of `the same clock than`

The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`.
(cherry picked from commit d0abd0b)

Co-authored-by: Alperen Keleş <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir easy
Projects
docs issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @picnixz @alpaylan