-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #2
Comments
Hey, thanks a lot for the feedback @perone. I'll respond to everything in detail shortly. |
So, for the first point: This is sort of intended. The I will fix the ATenConfig.cmake thing. Did that cause an error for your, or are you just mentioning it? It looks wrong, but I haven't seen errors from this yet. For documentation: Did you see the tutorial on exporting a model to C++ and loading it, https://pytorch.org/tutorials/advanced/cpp_export.html? Which tutorial would you liked to have had? I can write more. I will fix the I fixed the various Let me know your thoughts and thanks so much for all the very helpful feedback! |
Hi @goldsborough thanks a lot for the quick reply ! Regarding the Thanks again for the amazing work ! 👍 |
Summary: ezyang soumith Partly addresses pytorch/cppdocs#2 Pull Request resolved: #12521 Differential Revision: D10374244 Pulled By: goldsborough fbshipit-source-id: 8e9fe688cbaa2d2b0b96f721e5477ee8845b8f20
I fixed the |
Hey, I just did a simple integration of libtorch as an addon for nodejs. The API worked very nice and I really enjoyed the design, it's very well done ! I'm adding in this issue some feedbacks (don't know if here is the best place, but here you go):
torch::jit::load
isn't exposed by just adding thetorch/torch.h
header, you have to include thetorch/script.h
as well, don't know if it is intentional but it took me some time to find the right header, maybe a documentation improvement could help;share/cmake/ATen/ATenConfig.cmake
:/Users/administrator/nightlies/2018_10_01/wheel_build_dirs/libtorch_2.7/pytorch/torch/lib/tmp_install/include
;torch::jit::load
(https://pytorch.org/cppdocs/api/function_namespacetorch_1_1jit_1ace2c44fb8af5905ae17834e81086b8a3.html#exhale-function-namespacetorch-1-1jit-1ace2c44fb8af5905ae17834e81086b8a3)torch::nn
,torch::optim
,torch::data
,torch::serialize
,torch::jit
andtorch::python
)This is what I remember, if I see anything else I'll add it here as well.
The text was updated successfully, but these errors were encountered: