-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Indicate necessary context to run multiprocessed collectors in doc #2126
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2126
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 6 Unrelated FailuresAs of commit d425c25 with merge base 3c6b9c6 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @GJBoth! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@vmoens Could you help out here with the failed tests? Some of them failed due to main failing, and I didn't even touch code - just added docs -, so not sure why the CI on benchmarks is failing? |
Yeah those are broken tests on CUDA, I will handle that separately :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of formatting issues but we should be good to go after that!
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Just resolved the issues! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the docstrings for the
MultiSyncCollector
and `MultiaSyncCollector. It does several things:if __name__ == "__main__":
block.devices
andstoring_devices
kwargs don't exist - it needs to bedevice
andstoring_device
.cat_results="stack"
to follow future behaviour.main
branch also does not pass pre-commit, which is whytensor_specs.py
is changed too.I'm currently building the docs to see if everything looks good, but it's taking very long. Any advice there?