Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set global validate_args #871

Open
mctigger opened this issue Jul 11, 2024 · 0 comments · May be fixed by #872
Open

Do not set global validate_args #871

mctigger opened this issue Jul 11, 2024 · 0 comments · May be fixed by #872

Comments

@mctigger
Copy link

mctigger commented Jul 11, 2024 •
edited
Loading

tensordict/tensordict/nn/distributions/continuous.py

Line 25 in 02ff686

D.Distribution.set_default_validate_args(False)

Is there a reason for this line? I think it should be removed. validate_args is set to False when python is run in optimized mode (python -O) and True. The default should not be changed since errors may not be caught while developing.

#872
@vmoens vmoens linked a pull request Jul 12, 2024 that will close this issue
Removed global set_default_validate_args #872
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed global set_default_validate_args mctigger/tensordict
1 participant
@mctigger