Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoDetection() and CocoCaptions() should be replaced with MSCoco() #8771

Open
hyperkai opened this issue Dec 1, 2024 · 1 comment
Open

Comments

@hyperkai
Copy link

hyperkai commented Dec 1, 2024

🚀 The feature

It seems like CocoDetection() and CocoCaptions() are identical(same) according to the experiments which I did and the source code. *CocoDetection() is just renamed to CocoCaptions() by extending CocoDetection().

Motivation, pitch

So, CocoDetection() and CocoCaptions() should be replaced with MSCoco().

Alternatives

No response

Additional context

No response

@NicolasHug
Copy link
Member

Hi @hyperkai , can you share a minimal reproducing example showing that the output is exactly the same? The targets of CocoCations should be different:

def _load_target(self, id: int) -> List[str]:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants