-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericCompositor discards dataset metadata #2829
Comments
What value would you expect for a |
When I call the composite with |
Interesting idea, but I'm not sure how I feel about it. It is very likely that this request that specifically mentions wavelength could require a larger more generic solution for accessing all the information from dependencies used in a composite. Could you clarify what in the referenced documentation (the quickstart you linked to) you have a problem with? Is it that There are a couple complications with trying to implement something like this:
You mentioned:
What do you mean by "directly"? |
Describe the bug
Creating a composite with the
GenericCompositor
overwrites initial band/dataset metadata. This is also directly commented in the code itself although I find this behavior disputable:To Reproduce
with
scene
being an instance of Satpy'sScene
class.Calling the attributes of an individual dataset, e.g.
scene[3.8].attrs["wavelength"]
prints:3.8 µm (3.71-3.89 µm)
.Calling the attributes of the same dataset in the composite with
composite[0].attrs["wavelength"]
printsNone
.It is not possible to alter the dataset attributes within the composite.
Expected behavior
Discarding the original dataset attributes removes a lot of useful metadata and hampers visualization of the written composite file as crucial band information is missing. If band metadata would be forwarded or if there would be an option editing the metadata of the composite directly, further offline work with the saved image would be possible.
The text was updated successfully, but these errors were encountered: