Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mocking in eum_l2_grib reader tests #2932

Open
strandgren opened this issue Oct 16, 2024 · 0 comments
Open

Remove mocking in eum_l2_grib reader tests #2932

strandgren opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@strandgren
Copy link
Collaborator

Feature Request

Nowadays the preferred approach is to write a synthetic testing file to tmp_path and work with that instead. However the unit tests for the eum_l2_grib reader (test_eum_l2_grib.py) still uses mocking for creating test files. It shall be assessed if we can write synthetic test files also for the grib format and therefor get rid of the mocking.

@strandgren strandgren added enhancement code enhancements, features, improvements component:readers labels Oct 16, 2024
@strandgren strandgren self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

No branches or pull requests

1 participant