Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Matrix format is inefficient #1

Open
pzich opened this issue Apr 3, 2020 · 0 comments
Open

Pixel Matrix format is inefficient #1

pzich opened this issue Apr 3, 2020 · 0 comments

Comments

@pzich
Copy link
Owner

pzich commented Apr 3, 2020

asciify-pixel-matrix uses a pixel matrix in the following format:

[
  [{r: 255, g: 255, b: 255, a: 1}, {r: 255, g: 255, b: 255, a: 1}, ...],
  [{r: 255, g: 255, b: 255, a: 1}, {r: 255, g: 255, b: 255, a: 1}, ...],
  ...
]

This is very inefficient compared to the Buffer of bytes it already comes in as from ffmpeg, and all it does is immediately pull these values out to call asciify-pixel on each one. I suspect there will be a major performance improvement by bypassing this format and using something more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant