New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect shifting of byte array into double word #1

Open

jimbro1000 opened this issue Jan 5, 2023 · 1 comment

jimbro1000 commented Jan 5, 2023

drivewire4/drivewire4_from_source/drivewireserver-git/java/src/com/groupunix/drivewireserver/dwprotocolhandler/DWUtils.java

Line 21 in daf951d

    
           return( (data[0] & 0xFF) << 32) + ((data[1] & 0xFF) << 16) + ((data[2] & 0xFF) << 8) + (data[3] & 0xFF);

The MSB of the byte array is shifted by 32 bits instead of 24

Author

jimbro1000 commented Feb 11, 2023

This is fixed in the reworked maven build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment