-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven clean package - Error in Packaging Tests #47
Comments
Full log: |
Hi @muellerdo, thanks for reporting. I guess you don't have a running docker instance? That should be the issue since it is required by |
Hey @christopher-mohr, thanks for the fast response. A docker instance of a connected database or what do you mean with Testcontainers? Ah, or does the testing spawn new containers? |
Maybe, this can be interesting for this issue: |
You actually need docker to use |
Exactly. Sorry, I didn't see it before submitting my previous answer. :) |
Mhm, it seems that the problem requires a little bit of structure redesigning of our docker-compose. The problem is that testcontainers spawns containers in our container. This could be fixed when running a privileged instance or mount the docker socket into the container. As far as I understand this issue, we have now the following options:
Any other suggestions or ideas? I personally favor the |
Do you think we should keep the tests as part of the docker image? Would there be cases where we would use the docker image for untested code? |
I finally added a GitHub Action workflow for compiling, testing, packaging ( |
Hi @muellerdo, since there hasn't been any progress for a while, should I just merge your PR for now and take it from there? |
I have to apologize for the stalling.
This would be a good idea. Thank you! |
Heyho,
when running './mvnw clean compile' everything works fine.
However, when running './mvnw clean package', I obtained the following bug.
Seems like some tests are not working:
The text was updated successfully, but these errors were encountered: