diff --git a/starsky/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopApp.cs b/starsky/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopApp.cs index eeb1a099de..d4c10f7e8b 100644 --- a/starsky/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopApp.cs +++ b/starsky/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopApp.cs @@ -7,7 +7,7 @@ namespace starsky.foundation.native.OpenApplicationNative.Helpers; public static class WindowsOpenDesktopApp { /// - /// Add check if is Windows + /// Add check if is Windows /// /// full file paths /// running platform @@ -35,7 +35,7 @@ public static class WindowsOpenDesktopApp } /// - /// Does NOT check if file exists + /// Does NOT check if file exists /// /// Absolute Path of file /// @@ -60,7 +60,7 @@ public static class WindowsOpenDesktopApp } /// - /// Skip if is MacOS + /// Skip if is Mac OS /// /// /// @@ -76,7 +76,7 @@ public static class WindowsOpenDesktopApp } /// - /// Internal + /// Internal /// /// /// diff --git a/starsky/starskytest/FakeCreateAn/CreateAnXmp.cs b/starsky/starskytest/FakeCreateAn/CreateAnXmp.cs index 920dec2e58..021d1397f1 100644 --- a/starsky/starskytest/FakeCreateAn/CreateAnXmp.cs +++ b/starsky/starskytest/FakeCreateAn/CreateAnXmp.cs @@ -1,37 +1,35 @@ using System.Collections.Immutable; -using System.Diagnostics.CodeAnalysis; using System.Text; -namespace starskytest.FakeCreateAn +namespace starskytest.FakeCreateAn; + +public static class CreateAnXmp { - public static class CreateAnXmp - { - [SuppressMessage("ReSharper", "StringLiteralTypo")] - private static readonly string XmpString = - "2020-03-14T14:00:511/160011/54404019/10485761/1052,15.73N<" + - "/exif:GPSLatitude>6,2.37E252570:7:0:02020-03-14T14" + - ":00:51AppleiPhone SE<" + - "/tiff:Model>3Qdraw 1.02020-03-14T14:00:51Qdraw 1.0" + - "Extras2020-03-14T14:00:51Qdraw " + - "1.0" + - ""; - - public static readonly ImmutableArray Bytes = Encoding.ASCII.GetBytes(XmpString).ToImmutableArray(); - } + private const string XmpString = + "2020-03-14T14:00:511/160011/54404019/10485761/1052,15.73N<" + + "/exif:GPSLatitude>6,2.37E252570:7:0:02020-03-14T14" + + ":00:51AppleiPhone SE<" + + "/tiff:Model>3Qdraw 1.02020-03-14T14:00:51Qdraw 1.0" + + "Extras2020-03-14T14:00:51Qdraw " + + "1.0" + + ""; + + public static readonly ImmutableArray Bytes = + [..Encoding.ASCII.GetBytes(XmpString)]; } diff --git a/starsky/starskytest/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopAppTests.cs b/starsky/starskytest/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopAppTests.cs index b1aaea8913..5cf14f96d1 100644 --- a/starsky/starskytest/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopAppTests.cs +++ b/starsky/starskytest/starsky.foundation.native/OpenApplicationNative/Helpers/WindowsOpenDesktopAppTests.cs @@ -82,6 +82,7 @@ private static CreateFakeStarskyWindowsExe SetupEnsureAssociationsSet() [TestMethod] public void W_OpenDefault_NonWindows() { + // this does nothing var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault_NonWindows any value"], OSPlatform.Linux); @@ -89,7 +90,7 @@ public void W_OpenDefault_NonWindows() } [TestMethod] - public void W_OpenDefault2_NonWindows() + public void W_OpenDefault2_NonWindows_WithFlag() { if ( new AppSettings().IsWindows ) { @@ -97,14 +98,14 @@ public void W_OpenDefault2_NonWindows() return; } - var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault2_NonWindows any value"], + var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault2_NonWindows_WithFlag.txt"], OSPlatform.Windows); Assert.IsTrue(result); } [TestMethod] - public void W_OpenDefault3_NonWindows() + public void W_OpenDefault3_NonWindows_NoFlag() { if ( new AppSettings().IsWindows ) { @@ -112,9 +113,7 @@ public void W_OpenDefault3_NonWindows() return; } - var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault3_NonWindows any value"]); - - Console.WriteLine(result); + var result = WindowsOpenDesktopApp.OpenDefault(["W_OpenDefault3_NonWindows_NoFlag"]); Assert.IsTrue(result); }