Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGA driver reporting silly refresh rates #1

Open
rakslice opened this issue Nov 17, 2020 · 1 comment
Open

VGA driver reporting silly refresh rates #1

rakslice opened this issue Nov 17, 2020 · 1 comment

Comments

@rakslice
Copy link

rakslice commented Nov 17, 2020

Mac OS 9.2.x' Monitors control panel shows all modes as 0 Hz.

Judging by what macemu does with it, the csRefreshRate field in VDResolutionInfoRec is supposed to be 16.16 fixed point. As a hint, its type is a typedef of UInt32 called Fixed.

resInfo->csRefreshRate = 60;

So this should be e.g.

resInfo->csRefreshRate = 60 << 16; 
@rakslice rakslice changed the title Driver reporting silly refresh rates VGA driver reporting silly refresh rates Nov 17, 2020
mcayland pushed a commit to mcayland/QemuMacDrivers that referenced this issue Mar 2, 2022
As reported in qemu/QemuMacDrivers#1 by @rakslice
the monitor refresh rate is incorrectly being reported as 0Hz rather than 60Hz
since the resInfo->csRefreshRate field is not an integer but actually 16.16
fixed point.

Signed-off-by: Mark Cave-Ayland <[email protected]>
@mcayland
Copy link
Contributor

mcayland commented Mar 2, 2022

@rakslice thanks for the heads-up, and sorry for the delay. This is actually the QEMU (local) mirror of the original repository at https://github.com/ozbenh/QemuMacDrivers which is why no-one is really monitoring it.

I've applied your suggested change above and it seems to fix the issue for me: can you take a look at https://github.com/mcayland/QemuMacDrivers/tree/fix/monitor-refresh-rate and replace the .ndrv file in your QEMU share directory with the one at https://github.com/mcayland/QemuMacDrivers/raw/dc588ed5786d7cac353d88ad913717fba052de81/builds/qemu_vga.ndrv and confirm that you now see the monitor refresh rate being reported as 60Hz?

If that works for you, I'll raise a PR against the official repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants