error compiling cl-protobufs in order to install

[vchudnov-g]

I'm having problems installing cl-protobufs. I get errors like

g++ -std=c++14 -I/PATH/TO/MY/LOCAL/lisp/protobuf/include -I.   -c -o generator.o generator.cc
generator.cc: In member function ‘virtual bool google::protobuf::cl_protobufs::LispGenerator::Generate(const google::protobuf::FileDescriptor*, const std::string&, google::protobuf::compiler::OutputDirectory*, std::string*) const’:
generator.cc:62:5: error: ‘GOOGLE_CHECK’ was not declared in this scope
   62 |     GOOGLE_CHECK(annotations.SerializeToZeroCopyStream(meta.get()));
      |     ^~~~~~~~~~~~
generator.cc: In member function ‘virtual bool google::protobuf::cl_protobufs::LispGenerator::GenerateAll(const std::vector<const google::protobuf::FileDescriptor*>&, const std::string&, google::protobuf::compiler::GeneratorContext*, std::string*) const’:
generator.cc:135:5: error: ‘GOOGLE_CHECK’ was not declared in this scope
  135 |     GOOGLE_CHECK(annotations.SerializeToZeroCopyStream(meta.get()));
      |     ^~~~~~~~~~~~
make: *** [<builtin>: generator.o] Error 1

FWIW, I had to use different compilation steps for protobuf than what's included in your README, since protobuf seems to be currently set up for bazel or cmake builds. After trying various approaches, the following are the steps that wound up successfully compiling protobuf and installing it (and its include/) to a local user directory for me. I don't get an error until I try to compile cl-protobuf:

export PROTOC_ROOT=/PATH/TO/MY/LOCAL/lisp/protobuf
mkdir -p /tmp/lisp/proto
pushd /tmp/lisp/proto

git clone --recursive https://github.com/google/protobuf
pushd protobuf
git submodule update --init --recursive

mkdir -p ${PROTOC_ROOT}
cmake . -DCMAKE_CXX_STANDARD=14 -DCMAKE_INSTALL_PREFIX=${PROTOC_ROOT}
cmake --build . --parallel 10

cmake --install .
path-prepend ${PROTOC_ROOT}/bin
popd # protobuf

git clone [email protected]:qitab/cl-protobufs.git

pushd cl-protobufs/protoc
make  #### ****  <-- error occurs here

popd # cl-protobufs/protoc
popd # /tmp/lisp/proto

[Slids]

Thank you for the issue.
I've been pretty sick lately, but please know this
is on my list of things to look at!

[cgay]

@Slids I'm trying to build with Bazel instead of cmake because the protobuf/cmake/README.md only mentions Windows and Linux support, not macOS. If you export cl-protobufs/BUILD I can give it a shot.

Building protoc with bazel worked flawlessly...

git clone --recursive https://github.com/google/protobuf
cd protobuf/
brew install bazel
bazel build :protoc :protobuf
cp bazel-bin/protoc ~/bin/

I suspect I just need the following in my cl-protobufs/WORKSPACE file in order to build cl-protobufs/protoc, once I have the BUILD file.

workspace(name = "the-fantabulous-cl-protobufs-workspace")

local_repository(
    name = "com_google_protobuf",
    path = "../protobuf",  # assume installed in same dir as cl-protobufs
)

[cgay]

@Slids where are you?!!! I needz my BUILD filez!

[Slids]

Using CMake as done in the yaml CI files will work post:
#438

[Slids]

Protocol Buffers and ABSL both had some major changes, and I only (just barely) updated to a newer version of Prtocol Buffer used. Please check the SBCL-test.yaml file in the CI and the CMake file in protoc.