AccessEvent missing null check for RequestUrl

[aschepp]

I have the issue that requestUrl is logged as "null null null". This is because AccessEvent is missing a null check that exists in all methods except getRequestUrl.

public String getRequestURL() {
        if (requestURL == null) { // <- this has to be added.
            if (httpRequest != null) {
                StringBuilder buf = new StringBuilder();
                buf.append(httpRequest.getMethod());
                buf.append(AccessConverter.SPACE_CHAR);
                buf.append(httpRequest.getRequestURI());
                buf.append(getQueryString());
                buf.append(AccessConverter.SPACE_CHAR);
                buf.append(httpRequest.getProtocol());
                requestURL = buf.toString();
            } else {
                requestURL = NA;
            }
        }
        return requestURL;
    }

[ceki]

@aschepp Which servlet container are you using? Which version of logback-access?

The check is indeed missing. However, the null values might not be due to the missing check.

[aschepp]

I'm using

• Tomcat 10.1.23
• slf4j 2.0.13
• logback 1.5.6
• logback-access based on git version from 2024-04-29 (as a custom build to fix this issue)
• tomcat-slf4j-logback based on a recent git
• logstash-logback-encoder based on a recent git

[aschepp]

Before using the git version, I used version 2.0.1 of logback-access.

[aschepp]

The reason why I am saying, that the null check is important, is that the method prepareForDeferredProcessing does call getRequestUrl, but it's useless, because it's overwritten the next time getRequestUrl is called, because the null check is missing.