Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reflectance is not included in calculation of dark current #2

Open
phoebe-p opened this issue Feb 22, 2023 · 2 comments
Open
Assignees

Comments

@phoebe-p
Copy link
Member

In db_cell_calculation, the dark current/recombination current is currently calculated as:

        j01s[i] = (
            (pref / rad_eff)
            * (eg**2 + 2 * eg * (kbT) + 2 * (kbT) ** 2)
            * np.exp(-(eg) / (kbT))
        )

Which is the solution to the definite integral for J01 assuming no reflection and perfect absorption above the bandgap energy. This should be changed to included reflectance (and possibly non-perfect absorption if we want to consider more realistic cell calculations).

@phoebe-p phoebe-p self-assigned this Feb 22, 2023
@phoebe-p
Copy link
Member Author

Some quick tests show that introducing the numerical integral (either using the numpy trapz function or just by doing rectangular areas under the curve) is slower than the current analytical solution by about a factor of 300. Give the large difference, I think it is worth keeping the current method for the case that all the bandgaps are above the coloured wavelength range. It may also be worth just ignoring the effect on the dark current if the difference is negligible (the effect on current should be, but the effect on voltage might be more not negligible), but I haven't quantified this yet.

@phoebe-p
Copy link
Member Author

phoebe-p commented Mar 23, 2023

For rectangular reflectance peaks (of height 1 or otherwise), we can also use the indefinite integral:

kT (2 (kT)**2+2 kT E +E**2) (-exp((qV-E)/k)) + constant

and evaluate this piecewise in the areas where R = 0. This should not be much slower than the current analytical solution for the full range of integration.

@phoebe-p phoebe-p mentioned this issue Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant