Skip to content
This repository was archived by the owner on Sep 10, 2021. It is now read-only.

Can we use Control S to save #510

Open
2 tasks
TheWorldEndsWithUs opened this issue Jun 17, 2019 · 1 comment
Open
2 tasks

Can we use Control S to save #510

TheWorldEndsWithUs opened this issue Jun 17, 2019 · 1 comment

Comments

@TheWorldEndsWithUs
Copy link

Platform
How were you accessing the qri frontend?

  • app.qri.io
  • electron app
  • [ x] dev webapp

Version
What version of the Qri frontend are you using?
8.0.0

Describe the bug
A clear and concise description of what the bug is.

Whenever I hit control S it tries to save the webpage instead of the code I'm working on

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'transform'
  2. Press Control S

Expected behavior
For the code to save

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@ramfox
Copy link
Member

ramfox commented Jun 19, 2019

hi! The idea of adding keyboard shortcuts is super cool!

This is definitely something that needs thinking out before we put it into effect, as once a person is familiar with a set of default shortcuts it's hard to train them to change.

It's also compounded by the fact that we have both a webapp and an electron app. When using the webapp, we are accessing Qri through a browser that has its own keyboard short cuts, which is the discrepancy you are getting now. Ctrl-s when you are using a browser means "Save this webpage"

So, do we override browser shortcuts, even though it might subvert peoples expectations? Or do we only allow keyboard shortcuts using the electron app? Needs more thought, but its definitely something that should find its way into the app down the line.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants