Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg:not(:root) specificity (normalize.sass needs to be updated) #16132

Closed
AlexDaniel opened this issue Aug 1, 2023 · 2 comments
Closed

svg:not(:root) specificity (normalize.sass needs to be updated) #16132

AlexDaniel opened this issue Aug 1, 2023 · 2 comments

Comments

@AlexDaniel
Copy link

AlexDaniel commented Aug 1, 2023

What happened?

When combining Quasar with BabylonJS, normalize.sass styles are breaking the Node Material Editor in BabylonJS.

What did you expect to happen?

Quasar's css corrections should be neutral for most other libraries.

Reproduction URL

.

How to reproduce?

  1. Start a Quasar project
  2. Add BabylonJS to it
  3. Start the frontend and open the node material editor
  4. Drag the nodes around
  5. You'll see that the node connections are clipped

Actually, easier said than done… It's pretty straightforward but takes some time. Given that the fix is already in normalize.css, please let me know if I should actually provide something for reproducing this.

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Style & Identity (quasar)

Platforms/Browsers

Firefox, Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

Please see this ticket:

What happens is that BabylonJS is using an <svg> element that is arbitrarily sized, and then it expects the rendered elements to overflow.

However, quasar sets this style:

svg:not(:root)
  overflow: hidden

Which seems to change the default expectation. Therefore, content gets clipped.

This issue has been raised in normalize.css:

And it was resolved by this commit:

However, that change was not ported to Quasar yet. I think it should be.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Hi @AlexDaniel! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, StackBlitz, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

@rstoenescu
Copy link
Member

Hi,

Thanks for bringing this up. Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants