Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating is highlighted in a dialog, when clicking outside the dialog #16139

Open
siargei-stepanov opened this issue Aug 2, 2023 · 0 comments
Open
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@siargei-stepanov
Copy link

What happened?

I have a dialog, which has a rating component. When I click outside the dialog to close it, the rating's first star is highlighted. When the dialog has a setting no-backdrop-dismiss, then the dialog is not closed, but the first star is highlighted

Kapture 2023-08-02 at 14 00 18

What did you expect to happen?

Clicking outside of the dialog does not affect the rating component.

Here is an example of how the same code works in the Quasar v1. codepen

Reproduction URL

https://codepen.io/siargei-stepanov/pen/oNQmxOj

How to reproduce?

Case 1:

  1. Go to provided Codepen link
  2. Click on 'Alert' button. Dialog opens.
  3. Click (and hold) left mouse button outside of the dialog. Notice the first rating star is highlighted

Case 2:

  1. Go to provided Codepen link
  2. Click on 'Alert no backdrop dismiss' button
  3. Click outside of the dialog. Notice the dialog is not closed and the first rating star is highlighted

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

Components (quasar)

Platforms/Browsers

Firefox, Chrome, Safari

Quasar info output

Operating System - Darwin(22.5.0) - darwin/x64
NodeJs - 16.15.1

Global packages
  NPM - 8.11.0
  yarn - 1.22.19
  @quasar/cli - 2.2.1
  @quasar/icongenie - 2.5.3
  cordova - Not installed

Important local packages
  quasar - 2.12.2 -- Build high-performance VueJS user interfaces (SPA, PWA, SSR, Mobile and Desktop) in record time
  @quasar/app-webpack - 3.9.2 -- Quasar Framework App CLI with Webpack
  @quasar/extras - 1.16.5 -- Quasar Framework fonts, icons and animations
  eslint-plugin-quasar - Not installed
  vue - 3.3.4 -- The progressive JavaScript framework for building modern web UI.
  vue-router - 4.2.4
  pinia - Not installed
  vuex - 4.1.0 -- state management for Vue.js
  electron - Not installed
  electron-packager - Not installed
  electron-builder - Not installed
  @babel/core - 7.22.8 -- Babel compiler core.
  webpack - 5.88.1 -- Packs ECMAScript/CommonJs/AMD modules for the browser. Allows you to split your codebase into multiple bundles, which can be loaded on demand. Supports loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.
  webpack-dev-server - 4.11.1 -- Serves a webpack app. Updates the browser on changes.
  workbox-webpack-plugin - Not installed
  register-service-worker - 1.7.2 -- Script for registering service worker, with hooks
  typescript - 4.9.4 -- TypeScript is a language for application scale JavaScript development
  @capacitor/core - Not installed
  @capacitor/cli - Not installed
  @capacitor/android - Not installed
  @capacitor/ios - Not installed

Quasar App Extensions
  @quasar/quasar-app-extension-testing - 2.1.0 -- A Quasar App Extension for managing Test Harnesses
  @quasar/quasar-app-extension-testing-unit-jest - 3.0.0-beta.5 -- A Quasar App Extension for running Jest tests

Relevant log output

No response

Additional context

Maybe this issue is related to the current one

@github-actions github-actions bot added area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack labels Aug 2, 2023
@siargei-stepanov siargei-stepanov changed the title Rating is highlighted in dialog, when clicking outside dialog Rating is highlighted in a dialog, when clicking outside the dialog Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

1 participant