Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron window icon not being set #17657

Closed
delebash opened this issue Nov 22, 2024 · 1 comment
Closed

Electron window icon not being set #17657

delebash opened this issue Nov 22, 2024 · 1 comment
Labels
bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 mode/electron Qv2 🔝 Quasar v2 issues

Comments

@delebash
Copy link

What happened?

The icon specified in the electron main should be displayed in the upper left corner. The app name is changing correctly.

What did you expect to happen?

The electron window icon should display the correctly loaded icon

Reproduction URL

https://github.com/delebash/unreal_vault_organizer

How to reproduce?

Windows 11
npm 10.9.0
node 22.11.0
@quasar/app-vite 2.0.0-rc.3 (@quasar/cli 2.4.1)

  1. npm init quasar
  2. take the defaults except using vite v5 and javascript
  3. add electron via quasar mode add electron
  4. run the app quasar dev -m electron

The included quasar icon should be displayed in the upper left corner

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Electron Mode

Platforms/Browsers

Electron

Quasar info output

Operating System - Windows_NT(10.0.22631) - win32/x64
NodeJs - 22.11.0

Global packages
  NPM - 10.9.0
  yarn - Not installed
  pnpm - 9.12.3
  bun - Not installed
  @quasar/cli - 2.4.1
  @quasar/icongenie - 4.0.0
  cordova - Not installed

Important local packages
  quasar - 2.17.4 -- Build high-performance VueJS user interfaces (SPA, PWA, SSR, Mobile and Desktop) in record time
  @quasar/app-vite - 2.0.0-rc.3 -- Quasar Framework App CLI with Vite
  @quasar/extras - 1.16.13 -- Quasar Framework fonts, icons and animations
  eslint-plugin-quasar - Not installed
  vue - 3.5.13 -- The progressive JavaScript framework for building modern web UI.
  vue-router - 4.4.5
  pinia - Not installed
  vuex - Not installed
  vite - 5.4.11 -- Native-ESM powered web dev build tool
  vite-plugin-checker - Not installed
  eslint - Not installed
  esbuild - 0.24.0 -- An extremely fast JavaScript and CSS bundler and minifier.
  typescript - Not installed
  workbox-build - Not installed
  register-service-worker - Not installed
  electron - 33.2.0 -- Build cross platform desktop apps with JavaScript, HTML, and CSS
  @electron/packager - 18.3.6 -- Customize and package your Electron app with OS-specific bundles (.app, .exe, etc.) via JS or CLI
  electron-builder - Not installed
  @capacitor/core - Not installed
  @capacitor/cli - Not installed
  @capacitor/android - Not installed
  @capacitor/ios - Not installed

Quasar App Extensions
  *None installed*

Relevant log output

No response

Additional context

No response

@delebash delebash added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Nov 22, 2024
@github-actions github-actions bot added bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite mode/electron labels Nov 22, 2024
@delebash
Copy link
Author

Everything works as expected if you build the project using quasar build -m electron and then run the packaged exe
it just does not work in dev mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 mode/electron Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

1 participant