nodejs: add package.json support #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
force-pushed
the
npm-package-json
branch
from
a5750c3 to
cbc3f82
Compare
RTann
force-pushed
the
npm-package-json
branch
from
cbc3f82 to
88b457b
Compare
RTann
commented
Feb 22, 2023
crozzy
reviewed
Feb 28, 2023
RTann
force-pushed
the
npm-package-json
branch
3 times, most recently
from
43c053d to
ab13c9a
Compare
RTann
force-pushed
the
npm-package-json
branch
from
ab13c9a to
588400b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 52.43% 52.54% +0.11%
==========================================
Files 221 224 +3
Lines 16893 17005 +112
==========================================
+ Hits 8857 8936 +79
- Misses 7224 7251 +27
- Partials 812 818 +6 ☔ View full report in Codecov by Sentry. |
RTann
force-pushed
the
npm-package-json
branch
2 times, most recently
from
9131f9b to
c2553d6
Compare
RTann
force-pushed
the
npm-package-json
branch
from
c2553d6 to
8c938c5
Compare
|
Just for posterity I believe the idea is that this could be merged but not enabled by default (at least until we have a better idea of how the large number of added package affects performance). |
crozzy
reviewed
Jan 10, 2024
Signed-off-by: RTann <[email protected]>
RTann
force-pushed
the
npm-package-json
branch
from
8c938c5 to
70d2937
Compare
crozzy
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for analyzing NodeJS packages in the form of npm package.json.
Note: This does not currently account for the package.json files being installed due to an rpm. In that case, the package.json file should not be scanned.