Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocker: fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) #968

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

deshpandevlab
Copy link
Contributor

@deshpandevlab deshpandevlab commented Oct 1, 2024

The scale-down component was never rendered because of the incorrect path.
The clair-postgres and clair-app needed to scale back after the postgres upgrade.

This change ensures following flow in the case where clair is managed:

  • Scale down clair-app
  • Scale down clair-postgres
  • Upgrade clair-postgres
  • Scale up clair-postgres
  • Scale up clair-app

Testing

  • e2e tests
  • tested by deploying to the OC
  • tested for managed and unmanaged clair and postgres component

managed clair component for registry

shudeshp@shudeshp-mac ~ % oc get pods
NAME                                                  READY   STATUS              RESTARTS      AGE
shubhra-registry-clair-app-776c664cc7-8x54b           1/1     Running             0             14m
shubhra-registry-clair-app-776c664cc7-bmm8d           1/1     Running             0             15m
shubhra-registry-clair-postgres-5d6bb5bd9d-h87wp      1/1     Running             0             14m
shubhra-registry-clair-postgres-5d6bb5bd9d-nrf2m      0/1     ContainerCreating   0             14m
shubhra-registry-clair-postgres-old-85c795ddc-zst2j   1/1     Running             1 (14m ago)   15m
shubhra-registry-clair-postgres-upgrade-q9qws         0/1     ContainerCreating   0             15m
shubhra-registry-quay-app-754b596f7b-4pwrp            1/1     Running             2 (14m ago)   15m
shubhra-registry-quay-app-754b596f7b-4szrf            1/1     Running             3 (14m ago)   15m
shubhra-registry-quay-app-upgrade-vb2dh               0/1     Completed           0             16m
shubhra-registry-quay-database-6c6d5bc96f-2lb6p       1/1     Running             0             15m
shubhra-registry-quay-redis-d6d98bbfc-q7rbg           1/1     Running             0             15m

unmanaged clair component for registry

NAME                                                    READY   STATUS      RESTARTS      AGE
shubhra-registry-quay-app-fb9c7bfbd-mh9kl              1/1     Running     0             4m16s
shubhra-registry-quay-app-fb9c7bfbd-xw6xr              1/1     Running     0             4m16s
shubhra-registry-quay-app-upgrade-f57rt                0/1     Completed   0             5m5s
shubhra-registry-quay-config-editor-76444d4499-sklfl   1/1     Running     0             5m4s
shubhra-registry-quay-database-f5767b98-mkmg6          1/1     Running     0             5m4s
shubhra-registry-quay-redis-6bdf77fc56-7wvxm           1/1     Running     0             5m4s

Copy link

openshift-ci bot commented Oct 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deshpandevlab deshpandevlab marked this pull request as ready for review October 1, 2024 21:04
@deshpandevlab deshpandevlab changed the title Fixing recursed accumulation of path for managed clair resources Fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) Oct 2, 2024
@deshpandevlab deshpandevlab changed the title Fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) blocker: fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) Oct 4, 2024
@deshpandevlab
Copy link
Contributor Author

/test ocp-latest-e2e

Copy link

openshift-ci bot commented Oct 7, 2024

@deshpandevlab: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-latest-e2e c75c72f link true /test ocp-latest-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator

@jonathankingfc jonathankingfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathankingfc jonathankingfc merged commit 83828f5 into quay:master Oct 7, 2024
11 of 13 checks passed
@deshpandevlab
Copy link
Contributor Author

/cherrypick redhat-3.13

@bcaton85
Copy link
Collaborator

bcaton85 commented Oct 8, 2024

/cherry-pick redhat-3.13

@openshift-cherrypick-robot

@bcaton85: new pull request created: #970

In response to this:

/cherry-pick redhat-3.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants