Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgupgrade: add init container to delay startup of old deployment (PROJQUAY-8092) #984

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

deshpandevlab
Copy link
Contributor

waits for existing postgresql pod to scale down before the old pod is up

bcaton85 and others added 10 commits October 1, 2024 10:48
…y for authentication (PROJQUAY-2417) (quay#963) (quay#966)

Missed that we need the certificate handling in the mirror pod when using Postgres SSL authentication

Co-authored-by: Michaela Lang <[email protected]>
…ed clair resources (PROJQUAY-7993) (quay#970)

The scale-down component was never rendered because of the incorrect path.
The clair-postgres and clair-app needed to scale back after the postgres upgrade.

This change ensures following flow in the case where clair is managed:
- Scale down clair-app
- Scale down clair-postgres
- Upgrade clair-postgres
- Scale up clair-postgres
- Scale up clair-app

---------

Co-authored-by: Shubhra Deshpande <shubhrajayant+github.com>
@deshpandevlab deshpandevlab changed the title pgupgrade: added readinessProbe to old deployments donotmerge: pgupgrade: added readinessProbe to old deployments Oct 18, 2024
@bcaton85 bcaton85 changed the title donotmerge: pgupgrade: added readinessProbe to old deployments pgupgrade: add init container to delay startup of "old" deployment Oct 21, 2024
@bcaton85
Copy link
Collaborator

/ok-to-test

@deshpandevlab deshpandevlab changed the title pgupgrade: add init container to delay startup of "old" deployment pgupgrade: add init container to delay startup of "old" deployment (PROJQUAY-8092) Oct 21, 2024
@deshpandevlab deshpandevlab changed the title pgupgrade: add init container to delay startup of "old" deployment (PROJQUAY-8092) pgupgrade: add init container to delay startup of old deployment (PROJQUAY-8092) Oct 21, 2024
@bcaton85 bcaton85 merged commit d8bc894 into quay:master Oct 21, 2024
10 of 14 checks passed
@bcaton85
Copy link
Collaborator

/cherry-pick redhat-3.13

@openshift-cherrypick-robot

@bcaton85: #984 failed to apply on top of branch "redhat-3.13":

Applying: mirror(deployment-template): add postgresql client certificate overlay for authentication (PROJQUAY-2417) (#963) (#966)
Using index info to reconstruct a base tree...
M	kustomize/components/mirror/mirror.deployment.yaml
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: blocker: fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) (#970)
Using index info to reconstruct a base tree...
M	kustomize/components/clairpgupgrade/scale-down-clair/kustomization.yaml
M	pkg/kustomize/kustomize.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kustomize/kustomize.go
CONFLICT (content): Merge conflict in pkg/kustomize/kustomize.go
Auto-merging kustomize/components/clairpgupgrade/scale-down-clair/kustomization.yaml
CONFLICT (content): Merge conflict in kustomize/components/clairpgupgrade/scale-down-clair/kustomization.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 blocker: fixing recursed accumulation of path for managed clair resources (PROJQUAY-7993) (#970)

In response to this:

/cherry-pick redhat-3.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bcaton85 pushed a commit to bcaton85/quay-operator that referenced this pull request Oct 21, 2024
…JQUAY-8092) (quay#984)

waits for existing postgresql pod to scale down before the old pod is up

Co-authored-by: Shubhra Deshpande <shubhrajayant+github.com>
bcaton85 added a commit that referenced this pull request Oct 21, 2024
…JQUAY-8092) (#984) (#986)

waits for existing postgresql pod to scale down before the old pod is up

Co-authored-by: deshpandevlab <[email protected]>
@deshpandevlab deshpandevlab deleted the db branch October 22, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants