Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect: To upgrade to Reown WalletKit #176

Closed
sallymoc opened this issue Oct 6, 2024 · 3 comments · Fixed by #185
Closed

WalletConnect: To upgrade to Reown WalletKit #176

sallymoc opened this issue Oct 6, 2024 · 3 comments · Fixed by #185
Assignees
Labels
Enhancement New feature or request

Comments

@sallymoc
Copy link
Contributor

sallymoc commented Oct 6, 2024

WalletConnect Inc. is now known as Reown.

https://github.com/WalletConnect/WalletConnectFlutterV2 is no longer maintained.
We need to upgrade to Reown packages.

Some useful documentation about this here:
https://docs.reown.com/walletkit/upgrade/from-web3wallet-flutter

@sallymoc sallymoc added the Enhancement New feature or request label Oct 6, 2024
@sallymoc sallymoc moved this from Backlog to Ready in Wallet App Kanban Board Oct 6, 2024
@ahmed-tarek-salem ahmed-tarek-salem self-assigned this Oct 8, 2024
@ahmed-tarek-salem
Copy link
Contributor

The new package Reown has two conflicts with our packages:

1- package_info_plus: Reown uses it with version 7.0.0 and we use it with version 8.0.0 (We can't downgrade it at this time)
For this, there is an open issue:
reown-com/reown_flutter#9

2- share_plus: Reown uses web_socket_channel that depends on web 0.5.0, while share_plus depends on web 1.0.0
For this, I opened a new issue:
reown-com/reown_flutter#10

Downgrading our packages is not a valid option.

So now we have two options:

1- Upgrade to Reown and do manual overriding for those dependencies (I did it and it worked but it still needs to be tested very well as it might cause run time issues)
2- Keeping WalletConnect until fixing those two issues in the Reown package

So what do you think?

@sallymoc
Copy link
Contributor Author

sallymoc commented Oct 9, 2024

Blocked as we wait for the updates in the reown framework.

@ahmed-tarek-salem ahmed-tarek-salem linked a pull request Oct 20, 2024 that will close this issue
@sallymoc
Copy link
Contributor Author

sallymoc commented Nov 5, 2024

Update was done and already some bugs fixes. Other bugs will be reported separately.

@sallymoc sallymoc closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In QA to Done in Wallet App Kanban Board Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
2 participants