Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker-compose.yml into a /examples subdir, and add more? #68

Open
epugh opened this issue Mar 12, 2021 · 5 comments
Open

Move docker-compose.yml into a /examples subdir, and add more? #68

epugh opened this issue Mar 12, 2021 · 5 comments

Comments

@epugh
Copy link
Contributor

epugh commented Mar 12, 2021

I've written up some docker-compose.yml scripts for both MS SQL Server and MySQL. Should we move our "quickstart" docker-compose.yml into an /examples and then add more examples?

I'm happy to do this if folks think it would be a good enhancement.

@pbartusch
Copy link
Collaborator

I really like the suggestion as the docker-compose.yaml introduces just one possible quickstart solution for SMUI (another might be offered by https://github.com/querqy/chorus).

@mkr , @gunnarbusch : Any objections? Otherwise , I'd move the file.

@epugh
Copy link
Contributor Author

epugh commented Mar 20, 2021

we could have /examples/docker-compose-mysql.yaml, /examples/docker-compose-with-openid.yaml etc....

@pbartusch
Copy link
Collaborator

@epugh , cool idea. As docker-compose.yaml is a standard in the Docker universe I'd rather suggest something like:

/examples/smui+mysql/docker-compose.yaml
maybe add something like:
/examples/smui+postgres+openid/docker-compose.yaml in the future?

As there seems to be no objection from the authors ( @mkr , @gunnarbusch ) for any conflict , I will adjust the structure soon (and the corresponding documentation).

@gunnarbusch
Copy link
Contributor

Hi! It's a great idea to include multiple example setups in different docker-compose.yaml. @pbartusch You will need to modify the runE2ETests.sh since it's setting up an integration environment for the end-to-end tests.

@pbartusch
Copy link
Collaborator

Thank you , @gunnarbusch , for highlighting the dependency to the end-to-end test.
I see there should be no dependency from an (deployment relevant) end-to-end test towards an example docker-compose file.

Therefore, I tend to leave things as they are right now, and rather add examples to the querqy.org documentation.

@epugh , do you have an immanent example for docker setup , that deviates from the one provided (like for OpenID) , that would qualify for a first case to this scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants