Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memofields intent does not handle ICA owned validators #1488

Open
joe-bowman opened this issue Apr 24, 2024 · 2 comments
Open

Memofields intent does not handle ICA owned validators #1488

joe-bowman opened this issue Apr 24, 2024 · 2 comments

Comments

@joe-bowman
Copy link
Contributor

Summary of Bug

The parsing of the intent field expects 20 byte valAddr, but this can be 32-bytes in the event of a ICA controlled validator.

@joe-bowman
Copy link
Contributor Author

Supporting this means we have to length prefix the validator string.

Currently we can support:

Memo size: 256
After base64 overhead: 192
Minus prefix and field length: 190
190/21 (weight + addrbytes) = 9.04

With address length prefix, 190/22 = 8 vals (no change)
All 32 byte val addresses -> 5 vals (unlikely)

It makes the number of validators that can be selected dependent on which validators are selected, so needs to be considered alongside front end changes.

@joe-bowman
Copy link
Contributor Author

Note, this will require corresponding front end changes and must not be merged until the front end is updated ready to support on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant