-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend pad_to to pad_to_all_atomic_subtemplates #882
Comments
also the padding should allow to create the pulse as a single waveform,otherwise the convenience is lost
|
Everything AWG specific should go into
Do you mean the root PT? Where is then the difference to |
But is The usecase would be that I could imagine the user assuming this "padding" functionality to fix the awg quanta issue by extending the "same PT" object that the function is called on, but right now (maybe I'm missing the decisive step) a SequencePT is created which by default will be translated to two waveforms unless specified explicitly in create_program's |
Touché. One neat hack would be to add
One solution is to add a wavefrom padding functionality to pt = some_pt()
other_pt = some_other_pt(pt.duration) @ pt and the correctness of other_pt depends on the exact value of |
to increase convenience even more, the pad_to could be called from the top-level-pt to extend all atomic subtemplates to adhere to awg-specifications.
This is e.g. outlined in branch
feat/linspace_measurements
and should be simple to implementqupulse/qupulse/pulses/pulse_template.py
Line 442 in 6facb1f
Potentially for 1.0?
In that regard however, the PT time-extended in this manner should by default be translated into a single waveform, otherwise the convenience gets lost again.
The text was updated successfully, but these errors were encountered: