Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (optional?) bin-widths into the data files? #17

Open
manodeep opened this issue Oct 25, 2023 · 1 comment
Open

Add (optional?) bin-widths into the data files? #17

manodeep opened this issue Oct 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@manodeep
Copy link

manodeep commented Oct 25, 2023

The Baldry+2012 catalog contains the bin-widths as the second column. I am planning to use this catalog within an MCMC and therefore I would like to match the binning done in the data. However, since there is info about the bin-widths returned with the data, I can only guess as to what the widths were from diff'ing the x values. However, that produces two incorrect results:

  • the number of bin-widths will be 1-less than the number of x values
  • the correct bin-widths from the original catalog are 27 values like so [0.5, 0.5, 0.2, 0.2, ..., 0.2]. The diff produces 26 values of [0.5, 0.35, 0.2, 0.2, ..., 0.2]

I can handle this missing data within my workflow for this Baldry+2012 catalog but might be worthwhile to either implement/keep in mind for future use

@qyx268
Copy link
Owner

qyx268 commented Jan 22, 2024

This is a good suggestion. I will keep it open for future development.

As I wrote this package back then for simply showing models against data, there are a number of things worthy of further improvement. However, as none of this type of observational data provides covariance between bins, these to me are just different levels of approximation when writing the likelihood :(

@qyx268 qyx268 added the enhancement New feature or request label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants