Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 40 / GCC 14.2.1 platform #655

Open
donyunardi opened this issue Feb 25, 2025 · 5 comments
Open

Add Fedora 40 / GCC 14.2.1 platform #655

donyunardi opened this issue Feb 25, 2025 · 5 comments

Comments

@donyunardi
Copy link

donyunardi commented Feb 25, 2025

We found out today that CRAN is using Fedora 40 / GCC 14.2.1 for their CRAN check:
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/teal-00check.html

using R Under development (unstable) (2025-02-23 r87799)
using platform: x86_64-pc-linux-gnu
R was compiled by
    gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3)
    GNU Fortran (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3)
running under: Fedora Linux 40 (Workstation Edition)

Any chance this can be added as a new platform for r-hub?

@donyunardi donyunardi changed the title Add Fedora 40 platform Add Fedora 40 / GCC 14.2.1 platform Feb 25, 2025
@gaborcsardi
Copy link
Collaborator

What's wrong with the existing one?

@donyunardi
Copy link
Author

donyunardi commented Feb 25, 2025

I think that there's a different behavior with this platform.

When we submitted our package, we were told that there's a NOTE about non-standard files/directories:

checking for non-standard things in the check directory ... NOTE
Found the following files/directories:.renv’ ‘BiocManager

I couldn't replicate the error locally and I didn't see any NOTE in any if our r-hub workflow.
However, you will see this NOTE in the link that I provided earlier.

Here's one example where we use the r-hub gcc13 platform that's using Fedora 38 / GCC 13.2.1 and shows no NOTE: https://github.com/insightsengineering/teal/actions/runs/13479415105/job/37662762934

@gaborcsardi
Copy link
Collaborator

Surely, that has nothing to with the compiler or the Linux distro, but it is more about your test cleanup not working correctly:
https://github.com/cran/teal/blob/d61bcf61bd84cd000e9fba41652e03490633c935/tests/testthat.R#L4-L5

E.g. unlink() will not delete a directory, unless you use recursive = TRUE.

@donyunardi
Copy link
Author

Thanks for the tips, we'll give that a try.

Regardless, I think it would be nice to use the same platform that CRAN is using, so I'm checking if this is something r-hub would be interested in doing.

@gaborcsardi
Copy link
Collaborator

Sure, a PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants