Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styler always sends an e-mail when commenting on the repo #1008

Closed
MichaelChirico opened this issue Sep 26, 2022 · 3 comments · Fixed by #1012
Closed

styler always sends an e-mail when commenting on the repo #1008

MichaelChirico opened this issue Sep 26, 2022 · 3 comments · Fixed by #1012

Comments

@MichaelChirico
Copy link
Contributor

Every time I interact on the styler repo, I get a rather dull e-mail:

https://screenshot.googleplex.com/69nkbtPXwk42pNs

From poking around a little bit, it's caused by the pr-commands GHA:

https://github.com/r-lib/styler/blob/1f4437bf81c807da713eb1ec78b08e6a78002617/.github/workflows/pr-commands.yaml

(note: name: Commands which matches the e-mail).

I haven't quite figured out how to fix this -- should there be a placeholder job that always runs & succeeds immediately? That way when neither of the /document and /style commands are issued, at least something runs? Seems a bit silly. I haven't been able to find any related issues though.

@IndrajeetPatil
Copy link
Collaborator

This happens to me as well, and, a while back, I had reported it here.

So, yes, reproducible and is definitely something that should be fixed.

@lorenzwalthert
Copy link
Collaborator

I agree. Maybe worth investigating how our GHA files differ from the standard ones in r-lib/actions? Also, we don't actually need /style and /document actions really, because we have pre-commit.

@IndrajeetPatil
Copy link
Collaborator

IndrajeetPatil commented Sep 28, 2022

Yeah, I'd argue that we just get rid of the pr_commands workflow in favour of precommit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants