-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_description_defaults() contains invalid ORCID placeholder that throws error in R-devel #2059
Comments
It wouldn't be good to add a valid ORCID of someone that could end up with hundreds of packages on CRAN attributed... It works as a reminder for maintainers to add their own ORCID or delete it. |
I agree that hardcoding someone's real ORCID into usethis would be a bad idea. ORCID is optional in a DESCRIPTION, so I would propose usethis just remove the invalid placeholder from the default. |
The general philosophy of many usethis functions is to help people get fiddly files or bits of files in the correct form. That is the spirit of the ORCID placeholder here. It is much easier for someone to delete the placeholder if they don't wish to populate than it is for everyone else to look up the syntax (or, more likely, not bother with placing an ORCID even though they have one). So it's a question of net benefit to package developers. |
Ok, sounds good. I will work around this. |
Fixed by #2075. |
use_description_defaults()
contains an invalid ORCID placeholder here:usethis/R/description.R
Line 127 in 2cc9e5a
When a package containing this default ORCID placeholder is built, a recent change to R-devel now catches the invalid ORCID. This is happening in the unit tests for my R package which is now failing CRAN checks on R-devel:
https://cran.r-project.org/web/checks/check_results_DataPackageR.html
The text was updated successfully, but these errors were encountered: