Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not showing up in Pull request helpers article #2093

Closed
jonbry opened this issue Jan 20, 2025 · 2 comments
Closed

Images not showing up in Pull request helpers article #2093

jonbry opened this issue Jan 20, 2025 · 2 comments

Comments

@jonbry
Copy link

jonbry commented Jan 20, 2025

I noticed that the Pull request helpers article appears to be missing some images. For example, I think there should be an image shown here:

```{r, echo = FALSE}
#| fig-alt: Screenshot of the RStudio Git pane showing the file
#| R/adjective.R staged for a commit. The preview of the file
#| highlights the addition of the line "formidabel", with no comma
#| at the end of the line. The Commit message says
#| "Add 'formidable' to adjectives".
knitr::include_graphics("img/pr-functions-diff.png", dpi = 300)
```

This is what I see on the website:

I was able to reproduce this across multiple devices and browsers.

jennybc added a commit that referenced this issue Jan 23, 2025
closes #2093

I can't easily find a more elegant solution
@jennybc
Copy link
Member

jennybc commented Jan 23, 2025

I don't think my solution is truly correct, but I could not quickly figure out why the quotes in the alt text are causing problems, when they did not in the past. It feels like a change elsewhere in the knitr/pkgdown stack and I don't have time to get to the bottom of it right now. Just removing quotes seemed like a decent bandaid.

@jennybc
Copy link
Member

jennybc commented Jan 23, 2025

Note the fix will only show up in the dev site until the next usethis release (or I make some explicit effort to backport this fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants