-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider to add opentelemetry #261
Comments
What type of metrics will be available? From our perspective we're monitoring credits per consumer and number of active consumers (with their reference) to make sure that we always have active and alive consumers on streams. This is done via the http API today but it's quite ineffective and would be great if it was available as metrics but that might be out of context here? |
Those are server-side metrics. We'd like to add some client-side metrics. Not sure what. |
Specific metric solutions are an application level concern, not a library concern. Any OpenTelemetry instrumentation for the RabbitMq.Stream.Client library would need to be in a separate NuGet package to be injected at an application level. Since the event handlers and callbacks would need to be exposed anyways for any possible metrics solution, it might be best to just document a code snippet to connect the two. |
The common practice seems to be to put opentelemetry bits into opentelementry--contrib repos. So indeed a separate package |
Is your feature request related to a problem? Please describe.
It would be helpful to add https://opentelemetry.io/ SDK to the library.
Describe the solution you'd like
It would be helpful to add https://opentelemetry.io/ SDK to the library.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: