From 23a8609e26a5bb1b6fb8177914e74519d70af0d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Palancher?= <remi@rackslab.io>
Date: Tue, 20 Aug 2024 11:51:51 +0200
Subject: [PATCH] fix(front): hide users filter when auth disabled

Hide users disclosure from jobs filters panel when authentication is
disabled because gateway is unable to retrieve the list of users in this
case.

fix #330
---
 CHANGELOG.md                                      |  2 ++
 frontend/src/components/jobs/JobsFiltersPanel.vue | 14 +++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6f3f8e6e..db91ff2d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -34,6 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Support node names without digits in expand/fold logic (#328).
   - Update dependencies to fix CVE-2024-39338 (axios) and CVE-2024-6783
     (vue-template-compiler).
+  - Hide users disclosure from jobs filters panel when authentication is
+    disabled (#330).
 
 ## [3.1.0] - 2024-07-03
 
diff --git a/frontend/src/components/jobs/JobsFiltersPanel.vue b/frontend/src/components/jobs/JobsFiltersPanel.vue
index 61bb90bb..0af1db24 100644
--- a/frontend/src/components/jobs/JobsFiltersPanel.vue
+++ b/frontend/src/components/jobs/JobsFiltersPanel.vue
@@ -8,6 +8,7 @@
 
 <script setup lang="ts">
 import { useRuntimeStore } from '@/stores/runtime'
+import { useRuntimeConfiguration } from '@/plugins/runtimeConfiguration'
 import PartitionFilterSelector from '@/components/filters/PartitionFilterSelector.vue'
 import UserFilterSelector from '@/components/jobs/UserFilterSelector.vue'
 import AccountFilterSelector from '@/components/jobs/AccountFilterSelector.vue'
@@ -44,6 +45,7 @@ const props = defineProps({
 })
 
 const runtimeStore = useRuntimeStore()
+const runtimeConfiguration = useRuntimeConfiguration()
 
 const state_filters = [
   { value: 'completed', label: 'Completed' },
@@ -144,7 +146,17 @@ const state_filters = [
                   </div>
                 </DisclosurePanel>
               </Disclosure>
-              <Disclosure as="div" class="border-t border-t-gray-200 px-4 py-6" v-slot="{ open }">
+              <!--
+                Hide users filters disclosure panel when authentication is disabled. The list of
+                users are retrieved from authentication backend. When authentication is disabled,
+                the list of users cannot be retrieved.
+              -->
+              <Disclosure
+                v-if="runtimeConfiguration.authentication"
+                as="div"
+                class="border-t border-t-gray-200 px-4 py-6"
+                v-slot="{ open }"
+              >
                 <h3 class="-mx-2 -my-3 flow-root">
                   <DisclosureButton
                     class="flex w-full items-center justify-between bg-white px-2 py-3 text-sm text-gray-400"