Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SecretStore in container resource (Native Radius Way) for k8s Secrets. #7051

Closed
1 task
Tracked by #34
tdeheurles opened this issue Jan 19, 2024 · 5 comments
Closed
1 task
Tracked by #34
Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged

Comments

@tdeheurles
Copy link

tdeheurles commented Jan 19, 2024

Overview of feature request

Right now, Radius do not support secretstore for referring existing k8s secret as a volume in container. So we are have to use podSpec.

Maybe container resource could support this or a documentation could be present in secretstore as a starting point ?

Here is an example:

resource container 'Applications.Core/containers@2023-10-01-preview' = {
  name: 'ctnr-podpatch'
  location: location
  properties: {
    application: app.id
    container: {
      image: magpieimage
      ports: {
        web: {
          containerPort: port
        }
      }
    }
    connections: {}
    runtimes: {
      kubernetes: {
        pod: { // This is free-form object, you can use any kubernetes podSpec properties.
          containers: [
            {
              name: 'ctnr-podpatch' // ensure that it matches the container name above
              volumeMounts: [
                {
                  name: 'se-charlie-server'
                  mountPath: '/credentials'
                  readOnly: true
                }
              ]
            }
          ]
          volumes: [
            {
              name: 'se-charlie-server'
              secret: {
                secretName: 'se-charlie-server'
              }
            }
          ]
        }
      }
    }
  }
}

FYI @youngbupark

Acceptance criteria

Options:

Additional context

See the topic on discord forum

Would you like to support us?

  • Yes, I would like to support you

AB#10953

@tdeheurles tdeheurles added the feature This issue describes a feature request in Radius label Jan 19, 2024
@radius-triage-bot
Copy link

👋 @tdeheurles Thanks for filing this feature request.

A project maintainer will review this feature request and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@youngbupark
Copy link

@willtsai This is related to #5520. We need to support more use-cases of secretstore for containers. e.g. volume mount, secret reference in fields in container resource or any radius resource.

cc/ @rynowak

@rynowak
Copy link
Contributor

rynowak commented Jan 22, 2024

Yup. This is badly needed.

@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Jan 22, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@willtsai
Copy link
Contributor

this is completed as a part of #7744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

5 participants