Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown server #25

Open
huyntsgs opened this issue Jun 16, 2018 · 1 comment
Open

Graceful shutdown server #25

huyntsgs opened this issue Jun 16, 2018 · 1 comment

Comments

@huyntsgs
Copy link
Contributor

huyntsgs commented Jun 16, 2018 •
edited
Loading

When there is a join session in progress, server should wait the join completes before shutdown
@raedah
Copy link
Member

raedah commented Jun 16, 2018

Could be done as an server option to wait for the join to complete. Otherwise, the behavior could be to cleanly disconnect the clients before shutdown. Clients should cleanly handle and recover from possible server disconnects.

@huyntsgs huyntsgs changed the title Graceful shutdown server. When there is a join session in progrogress, server should wait the join completes before shutdown Graceful shutdown server. When there is a join session in progress, server should wait the join completes before shutdown Jun 17, 2018
@huyntsgs huyntsgs changed the title Graceful shutdown server. When there is a join session in progress, server should wait the join completes before shutdown Graceful shutdown server Jun 21, 2018
huyntsgs added a commit that referenced this issue Jun 29, 2018
@huyntsgs
Refactor code and fix issue #25
8243aeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huyntsgs @raedah