Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: Improve Precision in Geometric Calculations #44

Open
5 tasks
rafaeltonholo opened this issue Jun 3, 2024 · 0 comments
Open
5 tasks

EPIC: Improve Precision in Geometric Calculations #44

rafaeltonholo opened this issue Jun 3, 2024 · 0 comments
Labels
enhancement New feature or request epic A group of issues that can be broken down into a number of smaller issues

Comments

@rafaeltonholo
Copy link
Owner

The current implementation of the CLI tool, which parses SVG files to Compose Icons, is encountering issues with precision in geometric calculations. This precision loss affects the accuracy of the transformations applied to the SVG elements, resulting in visual discrepancies in the generated icons.

Currently, we are parsing Float to Double while calculating and back to Float, which could be avoided if we directly use Double.

Components to be migrated:

  • PathTransformation
  • ArcTransformation
  • Point2D (also merge PrecisePoint2D after migrating Point2D to use Double)
  • AffineTransformation
  • PathNodes
@rafaeltonholo rafaeltonholo added enhancement New feature or request epic A group of issues that can be broken down into a number of smaller issues labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request epic A group of issues that can be broken down into a number of smaller issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafaeltonholo