Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcuts in Windows Firefox do not work as expected #121

Open
benji1304 opened this issue Mar 11, 2024 · 8 comments
Open

Keyboard shortcuts in Windows Firefox do not work as expected #121

benji1304 opened this issue Mar 11, 2024 · 8 comments

Comments

@benji1304
Copy link

From here

https://help.raindrop.io/browser-extension/#tips--tricks

Open browser extension | Ctrl+Shift+E

This opens the Network tab in the dev console.

Firefox only: the hotkey for save current page / highlight is Alt+Shift+S

This opens the History menu.
@runesoe
Copy link

runesoe commented May 14, 2024

Some experience here.

@jdrch
Copy link

jdrch commented Jul 13, 2024 •
edited
Loading

Same problem here. Firefox Nightly x64 on Windows 11. Apparently the solution is to add _execute.action to the extension's manifest.json file. Does anyone know where that file is located? I searched the repo and couldn't find it, which is odd because per Mozilla all add-ons are required to have it.

OK, I think I found the issue. The legacy Manifest V2 extension has the keyboard shortcuts enabled in its manifest.json file, but the new Manifest V3 extension doesn't. I'm going to try creating a PR to fix that.

jdrch added a commit to jdrch/highlight that referenced this issue Jul 13, 2024
@jdrch
Restore Firefox extension keyboard shortcuts
7e3d913 
Restores Firefox extension keyboard shortcuts, which [currently don't work](raindropio/app#121). 

I took most of the code was taken from the[ legacy Manifest V2 extension `manifest.json`](https://github.com/raindropio/extensions/blob/master/src/config/manifest.json), except for changing `"_execute_browser_action"` to `"_execute_action"` for [Manifest V3 compatibility](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands#syntax)
This was referenced Jul 13, 2024
Closed
Open
@jdrch
Copy link

jdrch commented Jul 15, 2024

Update: Alt Shift B works for me. Anyone else?

@benji1304
Copy link
Author

benji1304 commented Jul 17, 2024 •
edited
Loading

Update: Alt Shift B works for me. Anyone else?

Nope, on firefox that opens the bookmarks menu for me (same as pressing alt+B or shift+B)

@jdrch
Copy link

jdrch commented Jul 18, 2024

Update: Alt Shift B works for me. Anyone else?

Nope, on firefox that opens the bookmarks menu for me (same as pressing alt+B or shift+B)

Welp, still waiting to hear anything at all about the fix I submitted.

@benji1304
Copy link
Author

@exentrich can you review?

@exentrich
Copy link
Member

It appears that in the latest version of Firefox on Windows, our current shortcuts cannot be used for our extension.

Could you suggest alternative shortcuts?
Here are some options I came up with, but I need your feedback:

  • Open extension: Alt+Shift+R
  • Save/highlight: Alt+Shift+A
  • Open sidebar: Alt+Shift+Z

What do you think?

@jdrch
Copy link

jdrch commented Jul 21, 2024

It appears that in the latest version of Firefox on Windows, our current shortcuts cannot be used for our extension.

Could you suggest alternative shortcuts?
Here are some options I came up with, but I need your feedback:

  • Open extension: Alt+Shift+R
  • Save/highlight: Alt+Shift+A
  • Open sidebar: Alt+Shift+Z

What do you think?

Those all work for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdrch @exentrich @benji1304 @runesoe