Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIFDecode test expects sifdecoder in PATH #10

Open
jfowkes opened this issue Feb 9, 2024 · 4 comments
Open

SIFDecode test expects sifdecoder in PATH #10

jfowkes opened this issue Feb 9, 2024 · 4 comments
Assignees

Comments

@jfowkes
Copy link
Contributor

jfowkes commented Feb 9, 2024

As found by @Letizia97
Running the SIFDecode test post installation fails unless sifdecoder is in the PATH:

$ cd $SIFDECODE/src ; make -f $SIFDECODE/makefiles/$MYARCH test

( cd decode ; make -f /home/vol04/scarf964/cutest/sifdecode/makefiles/pc64.lnx.gfo \
                     test PWD=/home/vol04/scarf964/cutest/sifdecode/src/decode )
make[1]: Entering directory `/home/vol04/scarf964/cutest/sifdecode/src/decode'
echo ""

echo " Decode unconstrained SIF file"
 Decode unconstrained SIF file
cd /home/vol04/scarf964/cutest/sifdecode/sif/ ; sifdecoder -A pc64.lnx.gfo ALLINITU
/bin/sh: sifdecoder: command not found

Surely the test should be using $SIFDECODE/bin/sifdecoder?

@jfowkes jfowkes changed the title SIFDecode tests expects sifdecoder in PATH SIFDecode test expects sifdecoder in PATH Feb 9, 2024
@nimgould
Copy link
Contributor

nimgould commented Feb 9, 2024

This is true, but of course a user is told to do this at the end of the install, viz

You should now add the following to your .bashrc file:
...
export PATH="${SIFDECODE}/bin:${PATH}
...

But yes, it certainly doen't hurt to add this entire path. I will add

@jfowkes
Copy link
Contributor Author

jfowkes commented Feb 9, 2024

Oh are they? I haven't been doing that for years...

@nimgould
Copy link
Contributor

nimgould commented Feb 9, 2024

I guess your Mac is so smart that it finds executables using AI :)

The message occurs at the end of the install (and says other things about man pages, etc)

If you don't do this, you won't be able to use sifdecoder standalone

@jfowkes
Copy link
Contributor Author

jfowkes commented Feb 9, 2024

Haha if only, I think I've just never needed to use standalone sifdecoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants