From c0a56a9b6d95435ec10e82876c538f58b29416a6 Mon Sep 17 00:00:00 2001
From: Mark Yen <mark.yen@suse.com>
Date: Thu, 28 Oct 2021 17:59:25 -0700
Subject: [PATCH] Update: address review comments

https://github.com/rancher-sandbox/rancher-desktop/pull/882#discussion_r738845806
https://github.com/rancher-sandbox/rancher-desktop/pull/882#discussion_r738848168

Signed-off-by: Mark Yen <mark.yen@suse.com>
---
 src/main/update/LonghornProvider.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/update/LonghornProvider.ts b/src/main/update/LonghornProvider.ts
index ca46d6dcadf..f43e18e2c0c 100644
--- a/src/main/update/LonghornProvider.ts
+++ b/src/main/update/LonghornProvider.ts
@@ -138,11 +138,11 @@ export async function hasQueuedUpdate(): Promise<boolean> {
     const stagedVersion = semver.parse(cache.release.tag, { loose: true });
 
     if (!currentVersion || !stagedVersion) {
-      console.log(`Error parsing staged versions: ${ currentVersion } -> ${ stagedVersion }`);
+      console.log(`Error parsing staged versions: ${ currentVersion ?? '<none>' } -> ${ stagedVersion ?? '<none>' }`);
 
       return false;
     }
-    if (currentVersion.compare(stagedVersion) >= 0) {
+    if (semver.gte(currentVersion, stagedVersion)) {
       console.log(`Staged version ${ stagedVersion } not greater than current version ${ currentVersion }, skipping.`);
 
       return false;