Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: cuGraph is using thrust::binary_function which was deprecated in main CCCL's branch #4858

Open
2 tasks done
caugonnet opened this issue Jan 10, 2025 · 1 comment
Open
2 tasks done
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@caugonnet
Copy link

Version

cudastf (main + main CCCL)

Which installation method(s) does this occur on?

Source

Describe the bug.

Hello,

This is a forward looking bug report, but in the context of the "cudastf" branch which attempts to build cuGraph with the most recent version of CCCL, I have encountered this error : thrust::binary_function was deprecated, so to eventually upgrade CCCL, the property_op class will need to be rewritten in PRIMS algorithms

home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(132): error: namespace "thrust" has no member class "binary_function"
        binary_function<thrust::tuple<Args...>, thrust::tuple<Args...>, thrust::tuple<Args...>> {
        ^

/home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(132): error: class or struct definition is missing
        binary_function<thrust::tuple<Args...>, thrust::tuple<Args...>, thrust::tuple<Args...>> {
                       ^

/home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(148): warning #12-D: parsing restarts here after previous syntax error
  };
   ^

Minimum reproducible example

git checkout cudastf
mkdir -p cpp/build/
cd cpp/build/

cmake ../  -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_CUDA_COMPILER=nvcc -DCMAKE_CUDA_ARCHITECTURES=86  -DBUILD_CUGRAPH_MG_TESTS=ON

make -j8 -k # -k because there might be other CCCL-update related bugs

Relevant log output

home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(132): error: namespace "thrust" has no member class "binary_function"
        binary_function<thrust::tuple<Args...>, thrust::tuple<Args...>, thrust::tuple<Args...>> {
        ^

/home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(132): error: class or struct definition is missing
        binary_function<thrust::tuple<Args...>, thrust::tuple<Args...>, thrust::tuple<Args...>> {
                       ^

/home/caugonnet/git/caugonnet_cugraph/cpp/src/prims/property_op_utils.cuh(148): warning #12-D: parsing restarts here after previous syntax error
  };
   ^

Environment details

Other/Misc.

$ nvidia-smi 
Fri Jan 10 09:23:25 2025       
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.54.15              Driver Version: 550.54.15      CUDA Version: 12.4     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@caugonnet caugonnet added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jan 10, 2025
@caugonnet caugonnet changed the title [BUG]: [BUG]: cuGraph is using thrust::binary_function which was deprecated in main CCCL's branch Jan 10, 2025
@caugonnet
Copy link
Author

PR #4859 should fix it : we simply do not need the inherited base class anymore ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants